Skip to content

[eas-cli] Fix Convex invite output#3672

Merged
FiberJW merged 1 commit intomainfrom
fiberjw/fix-convex-invite-output
May 4, 2026
Merged

[eas-cli] Fix Convex invite output#3672
FiberJW merged 1 commit intomainfrom
fiberjw/fix-convex-invite-output

Conversation

@FiberJW
Copy link
Copy Markdown
Member

@FiberJW FiberJW commented May 4, 2026

Why

The Convex connect flow could tell users to check their email even when they rejected the invite resend prompt. Convex team invite timestamps were also shown as raw ISO strings, and linked team displays did not expose whether a team had already been claimed.

How

  • Track whether the connect command actually sent, skipped, or failed the team invite, and only print the email follow-up when an invite was sent.
  • Select hasBeenClaimed in the shared Convex team connection GraphQL fragment and use it to skip invite prompts for already-claimed teams.
  • Display claimed state in Convex team output and team invite output.
  • Format invite timestamps as human-readable UTC strings in displays and resend prompts.

Test Plan

Run convex team commands on a project/account that has a team that's already claimed. It shouldn't sent invitations or tell you to check your email:

Screenshot 2026-05-05 at 04 32 07 Screenshot 2026-05-05 at 04 32 29 Screenshot 2026-05-05 at 04 32 25

Copy link
Copy Markdown
Member Author

FiberJW commented May 4, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@FiberJW FiberJW marked this pull request as ready for review May 4, 2026 19:01
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@FiberJW FiberJW force-pushed the fiberjw/fix-convex-invite-output branch from b36fee9 to c2e59bb Compare May 4, 2026 19:02
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.32%. Comparing base (51311f1) to head (508a6a4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3672      +/-   ##
==========================================
+ Coverage   56.31%   56.32%   +0.02%     
==========================================
  Files         879      879              
  Lines       38004    38017      +13     
  Branches     7902     7906       +4     
==========================================
+ Hits        21397    21410      +13     
  Misses      16509    16509              
  Partials       98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FiberJW FiberJW force-pushed the fiberjw/fix-convex-invite-output branch from c2e59bb to 508a6a4 Compare May 4, 2026 19:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

✅ Thank you for adding the changelog entry!

@FiberJW FiberJW requested a review from mackenco May 4, 2026 19:33
@FiberJW FiberJW merged commit b5fac2a into main May 4, 2026
11 checks passed
@FiberJW FiberJW deleted the fiberjw/fix-convex-invite-output branch May 4, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants